Conversation
6ad9c14 to
f8b8959
Compare
|
Imo, either |
2c11df3 to
a266aa3
Compare
|
@ndossche It would be good to have your review on this. @remicollet I considered making an @alecpl I think |
|
@tstarling I'm sorry but I'm taking a step back from PHP, so someone else will need to review this. |
a266aa3 to
09a25f1
Compare
- Add a $flags parameter to ZipArchive::openString(), by analogy with ZipArchive::open(). This allows the string to be opened read/write. - Have the $data parameter to ZipArchive::openString() default to an empty string, for convenience of callers that want to create an empty archive. This works on all versions of libzip since the change in 1.6.0 only applied to files, it's opt-in for generic sources. - Add ZipArchive::closeString() which closes the archive and returns the resulting string. For consistency with openString(), return an empty string if the archive is empty. - Wrap strings passed to libzip with zip_source_function_create() instead of using zip_source_buffer_create(). This allows us to make the string writable, and simplifies memory management.
09a25f1 to
283c75c
Compare
@alecpl I renamed it from |
Uh oh!
There was an error while loading. Please reload this page.